Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to boto3 default connection #5246

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Add support to boto3 default connection #5246

merged 1 commit into from
Feb 24, 2025
+13 −3

Conversation

Omarlsg98
Copy link
Contributor

@Omarlsg98 Omarlsg98 commented Feb 21, 2025 •
edited by KevinHuSh
Loading

What problem does this PR solve?

This pull request includes changes to the initialization logic of the ChatModel and EmbeddingModel classes to enhance the handling of AWS credentials.

Use cases:

  • Use env variables for credentials instead of managing them on the DB
  • Easy connection when deploying on an AWS machine

Type of change

  • New Feature (non-breaking change which adds functionality)

@Omarlsg98 Omarlsg98 changed the title adds support to boto3 default connection Add support to boto3 default connection Feb 21, 2025
@KevinHuSh KevinHuSh added the ci Continue Integration label Feb 24, 2025
@KevinHuSh KevinHuSh merged commit 4f2816c into infiniflow:main Feb 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci Continue Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Omarlsg98 @KevinHuSh