Dynamically create the service_conf.yaml file by replacing environment variables from .env #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
writinwaters
approved these changes
Nov 12, 2024
|
Also, thanks for the painstaking edits to the README and docs! |
|
The CI is blocked due to unable to connect to ragflow-server. Need to investigate why. |
yuzhichang
force-pushed
the
replace-env-vars-in-service-conf-file
branch
from
d17ef33 to
bc14c4a
Compare
|
Fixed code to pass CI. |
|
@yuzhichang thanks for fixing it, pretty sure it worked when I tested it a few days ago. But I like it better if it is done all in the Will you close the corresponding issue #3322. I have created or should I do it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This pull request implements the feature mentioned in #3322.
Instead of manually having to edit the
service_conf.yamlfile when changes have been made to.envand mapping it into the docker container at runtime, a template file is used and the values replaced by the environment variables from the.envfile when the container is started.Type of change