fix bugs in test #3196
Merged
fix bugs in test #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzhichang
reviewed
Nov 5, 2024
| if document_ids is None: | ||
| document_ids = [] | ||
| data_json ={ | ||
| "offset": offset, | ||
| "limit": limit, | ||
| "offset": page, |
| @@ -45,7 +45,7 @@ def test_list_documents_in_dataset_with_success(get_api_key_fixture): | |||
| blob = b"Sample document content for test." | |||
| document_infos = [{"displayed_name": "test.txt","blob":blob}] | |||
| ds.upload_documents(document_infos) | |||
| ds.list_documents(keywords="test", offset=0, limit=12) | |||
| ds.list_documents(keywords="test", page=0, page_size=12) | |||
There was a problem hiding this comment.
page defaults to 1, page_size defaults to 30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix bugs in test
Type of change