Feat:Compatible with Dify's External Knowledge API #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Howe829
force-pushed
the
feat/retrieval_api
branch
from
6ffa145 to
60fe7a6
Compare
KevinHuSh
reviewed
Oct 15, 2024
KevinHuSh
reviewed
Oct 15, 2024
api/apps/sdk/retrieval.py
Outdated
| from utils.api_utils import validate_request, build_error_result, apikey_required | ||
|
|
||
|
|
||
| @manager.route('/retrieval', methods=['POST']) |
There was a problem hiding this comment.
Suggested change
| @manager.route('/retrieval', methods=['POST']) | |
| @manager.route('/dify_retrieval', methods=['POST']) |
There was a problem hiding this comment.
Thanks for your comment but the api request url needs to be "endpoint/retrieval".
https://docs.dify.ai/guides/knowledge-base/external-knowledge-api-documentation
There was a problem hiding this comment.
I've added dify to url prefix and changed the filename, PTAL.
1 task
5 tasks
Sorry for the bug.I am quite busy recently, so I have no time to deal with it. Thanks for your fix! |
|
already solved in #3076 |
Halfknow
pushed a commit
to Halfknow/ragflow
that referenced
this pull request
Nov 11, 2024
### What problem does this PR solve? _Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR._ Fixes infiniflow#2731 ### Type of change - [x] New Feature (non-breaking change which adds functionality)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.
Fixes #2731
Type of change