This repository has been archived by the owner on Jul 6, 2022. It is now read-only.
forked from sql-formatter-org/sql-formatter
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #17, add dedupe with Set
Refresh vscode subrepo
Add VSCode Command to format current selection
Add error handling and SQL Flavour override
inferrinizzard
commented
Dec 23, 2021
return inlineWidth > this.lineWidth; | ||
} else if (this.newline.mode === NewlineMode.hybrid) { | ||
return numItems > this.newline.itemCount! || inlineWidth > this.lineWidth; | ||
} else if (!Number.isNaN(this.newline)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add comment
inferrinizzard
added a commit
that referenced
this pull request
Dec 23, 2021
* consume vscode extension * update languageMap * update vscode README * add vscode issue template * ignore vscode from eslint as subrepo * update NewlineMode option, remove itemCount * update demo page, readme * update vscode extension * indent ; on tenSpace * update newline short circuiting * refresh license * clean .vscode * update linesBetweenQuery logic * fix test tabbing * add empty BigQueryFormatter class * add bigquery keywords * add test file * use numeric for loop in Formatter * add BigQuery specific tests * update vscode file type * add empty HiveFormatter class * added language items and updated tests * add ref link * update vscode file type * fix case test * ♻️ * add dedupe with Set * add vscode workspace * rename linesBetweenStatements * yo code reset * move settings to util function * add format selection command * add settings to override vscode tab settings * add command to format selection * ♻️ * add error message on format fail * add SQL flavour override * rename tests to *.test.js schema * rename Formatter classes to *.formatter.ts * update README * update issue templates * update CONTRIBUTING * update vscode README * update CHANGELOG * fix plsql filename * update vscode CHANGELOG
inferrinizzard
added a commit
that referenced
this pull request
Dec 23, 2021
* consume vscode extension * update languageMap * update vscode README * add vscode issue template * ignore vscode from eslint as subrepo * update NewlineMode option, remove itemCount * update demo page, readme * update vscode extension * indent ; on tenSpace * update newline short circuiting * refresh license * clean .vscode * update linesBetweenQuery logic * fix test tabbing * add empty BigQueryFormatter class * add bigquery keywords * add test file * use numeric for loop in Formatter * add BigQuery specific tests * update vscode file type * add empty HiveFormatter class * added language items and updated tests * add ref link * update vscode file type * fix case test * ♻️ * add dedupe with Set * add vscode workspace * rename linesBetweenStatements * yo code reset * move settings to util function * add format selection command * add settings to override vscode tab settings * add command to format selection * ♻️ * add error message on format fail * add SQL flavour override * rename tests to *.test.js schema * rename Formatter classes to *.formatter.ts * update README * update issue templates * update CONTRIBUTING * update vscode README * update CHANGELOG * fix plsql filename * update vscode CHANGELOG
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tabSize
andinsertSpaces
sql
files with custom SQL Flavournewline
confignever
modehybrid
, passing a number now works like hybridsemicolonNewline
andtenSpace
linesBetweenQueries
to count number of spaces instead of newlines