This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Share ImmutableSets #203
Merged
Share ImmutableSets #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergeFrom now reuses ImmutableSet instances where possible, reducing the memory overhead of the modify-rebuild pattern.
alicederyn
force-pushed
the
shared.sets
branch
from
c5ad31e to
6e634cc
Compare
j-baker
suggested changes
Oct 11, 2016
| .addLine("public %s<%s> %s() {", Set.class, elementType, getter(property)); | ||
| if (code.feature(GUAVA).isAvailable()) { | ||
| code.addLine(" if (%s instanceof %s) {", property.getName(), ImmutableSet.class) | ||
| .addLine(" %1$s = new %2$s%3$s(%1$s);", |
| .addLine("public %s %s() {", metadata.getBuilder(), clearMethod(property)); | ||
| if (code.feature(GUAVA).isAvailable()) { | ||
| code.addLine("if (%s instanceof %s) {", property.getName(), ImmutableSet.class) | ||
| .addLine(" %s = %s.of();", property.getName(), ImmutableSet.class) |
j-baker
approved these changes
Oct 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mergeFrom now reuses ImmutableSet instances where possible, reducing the memory overhead of the modify-rebuild pattern.
This PR is part of issue #169.