Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3775: Upgrade github-pages to 232 to Support Ruby 3.3 for Local YARD Documentation #640

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

vanessuniq
Copy link
Contributor

Summary

After upgrading to Ruby 3.3, bundle exec jekyll serve no longer worked due to compatibility issues with the existing version of github-pages. This PR updates github-pages to version 232, resolving the issue and allowing the local YARD documentation to be served correctly.

Testing Guidance

Follow these steps to verify the fix:

./bin/docs
cd docs/
bundle install
bundle exec jekyll serve

Open http://localhost:4000/inferno-core/docs/ in a browser and confirm that the documentation renders correctly.

Signed-off-by: Vanessa Fotso <vfotso@mitre.org>
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (c003d52) to head (a2ea8c5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #640   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files         286      286           
  Lines       12875    12875           
  Branches     1596     1596           
=======================================
  Hits        10908    10908           
  Misses       1959     1959           
  Partials        8        8           
Flag Coverage Δ
backend 92.08% <ø> (ø)
frontend 79.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vanessuniq vanessuniq merged commit a81794d into main Mar 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants