Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3731: Modify cursor behavior to allow tooltips in report #625

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

AlyssaWang
Copy link
Contributor

Summary

Refactors cursor behavior to allow tooltips on hover. Also removes the ability for expansion to be modified via tab-through keyboard events. Changes cursor to default instead of pointer in this use case.

Testing Guidance

Mouse over icons in report view -- tooltips should appear.
Click expansion and tab-through keyboard expansion of accordion items should be disabled.

@AlyssaWang AlyssaWang requested review from arscan and mrnosal February 15, 2025 03:04
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.71%. Comparing base (7ff73ea) to head (27eeb25).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #625   +/-   ##
=======================================
  Coverage   84.71%   84.71%           
=======================================
  Files         283      283           
  Lines       12404    12408    +4     
  Branches     1503     1503           
=======================================
+ Hits        10508    10512    +4     
  Misses       1888     1888           
  Partials        8        8           
Flag Coverage Δ
backend 92.33% <ø> (ø)
frontend 79.21% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mrnosal mrnosal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tooltips shown as expected. cannot expand/collapse test groups using keyboard.

@AlyssaWang AlyssaWang merged commit bc972fe into main Feb 20, 2025
10 checks passed
@AlyssaWang AlyssaWang deleted the FI-3731-report-tooltips branch February 20, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants