Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3678: Update runnable context to support use when describing non-runnables #607

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

Jammjammjamm
Copy link
Collaborator

This branch updates the runnable context to support using the runnable spec helpers when describing a non-runnable (e.g., a module that is included in runnables).

@Jammjammjamm Jammjammjamm self-assigned this Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (9e06950) to head (1509b0b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files         283      283           
  Lines       12415    12415           
  Branches     1503     1503           
=======================================
  Hits        10519    10519           
  Misses       1888     1888           
  Partials        8        8           
Flag Coverage Δ
backend 92.32% <ø> (ø)
frontend 79.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karlnaden
Copy link
Contributor

I've tried using this in the PAS test kit, but run into an error on all examples in that spec that I can't decipher:

Failure/Error: DatabaseCleaner.cleaning { example.run }
       DaVinciPASTestKit::PasBundleValidation does not implement: suite
     # ./spec/spec_helper.rb:113:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:113:in `block (2 levels) in <top (required)>'

Did I miss a step? That DatabaseCleaner.cleaning { example.run } step appears to be in the inferno-core SpecHelper. Is this getting hit before the changed code mocks a response to suite?

@Jammjammjamm Jammjammjamm force-pushed the fi-3678-fix-runnable-specs branch from 3f0dc52 to a107751 Compare February 12, 2025 13:27
@Jammjammjamm
Copy link
Collaborator Author

@karlnaden Yes, that line wraps the spec, so annoyingly errors in before blocks are getting caught and reported as coming from there. I made an update that should hopefully fix the issue you were having.

Copy link
Contributor

@karlnaden karlnaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this fix in the following test kits:

@Jammjammjamm Jammjammjamm merged commit 513af1f into main Feb 12, 2025
10 checks passed
@Jammjammjamm Jammjammjamm deleted the fi-3678-fix-runnable-specs branch February 12, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants