Streamline building I #552
Conversation
Binaries from GCC >= 5 are ABI compatible within their major versions.
This fixes bugs and compatiblity problems all over the place. It gets us compatible with Conan 1.0, fixes Compiler errors and warnings, problems with certain Python versions. Also has some further small progress on macOS.
Croydon
force-pushed
the
croydon/streamline_building
branch
from
6e1aa2c to
3ec42e8
Compare
| elseif(OS_MACOSX) | ||
| add_executable(${exe} MACOSX_BUNDLE ${sources}) | ||
| elseif(OS_MACOS) | ||
| add_executable(${exe} MACOS_BUNDLE ${sources}) |
There was a problem hiding this comment.
This should be reverted: https://cmake.org/cmake/help/v3.0/prop_tgt/MACOSX_BUNDLE.html
There was a problem hiding this comment.
Since this makes no practial difference right now (build fails long before this step), I will revert this in further pull requests.
| args += ["-DBUILD_SERVER=1"] | ||
| if self.scope.build_master or self.scope.build_all: | ||
| if 'build_master' in os.environ or 'build_all' in os.environ: |
There was a problem hiding this comment.
These two lines can be omitted since there is no BUILD_MASTER anymore.
There was a problem hiding this comment.
Will do in further PRs.
| bool Execute(const CefString& name, CefRefPtr<CefV8Value> object, const CefV8ValueList& arguments, CefRefPtr<CefV8Value>& retval, CefString& exception) override; | ||
| bool Get(const CefString& name, const CefRefPtr<CefV8Value> object, CefRefPtr<CefV8Value>& retval, CefString& exception) override; | ||
| bool Set(const CefString& name, const CefRefPtr<CefV8Value> object, const CefRefPtr<CefV8Value> value, CefString& exception) override; | ||
| std::string GetContextName() override { return "layer"; }; |
There was a problem hiding this comment.
Im not so sure about the "override" changes.
They seem to be incomplete.
I ran clang-tidy to do it in another branch and it resulted in way more override additions. (could be that I made some changes which required those additional overrides though)
Anyways, better than nothing, so just a note.
There was a problem hiding this comment.
I didn't notice more warnings, so I guess your work introduced them somehow.
| #language: cpp | ||
| #compiler: clang | ||
| #env: docker_tag="NODOCKER" compiler=clang TARGET="osx" CMAKE_FLAGS="-DCMAKE_CXX_COMPILER=clang++-3.9 -DCMAKE_C_COMPILER=clang-3.9 -DBUILD_ALL=1" | ||
| #CI - os: osx |
There was a problem hiding this comment.
someday I'd like to split travis.yml again in two files to make this pipeline a bit more intuitively understandable :D ive no clue atm since "CI" is pretty ambigous
not now though
|
|
||
|
|
||
| ## increment the version number based on the last tag. | ||
| incremented_version() |
There was a problem hiding this comment.
you could leave this incremented_version and stuff out, but I assume you just copied it, so its fine for now.
But we need to remove the clutter later.
There was a problem hiding this comment.
Sure, this is heavily work in progress.
|
AppVeyor has some issues right now. It did build successful, but did report the status only back for the "pr" status, not for the "branch" status. I'm going to merge now anway. |
ghost
removed
the
This fixes bugs and compatibility problems all over the place.
It gets us compatible with Conan 1.0, fixes Compiler errors and warnings, fixes problems with certain Python versions.
Also has some further progress on macOS: We are building and uploading now the first Conan packages! (#385)
This was an unpleasant job and is much more work as these few commits suggest. I'm really happy that our build env is becoming much more stable overall.
It still have some bigger bullet points for our build env on my to do list, but I will shift my personal focus slowly towards the C++ side of things :)