Allow WhenVisible
Component to Accept params
Alongside data
for Enhanced Customization
#2065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
getReloadParams
function to allow users to pass bothdata
and customparams
when using theWhenVisible
component in Inertia v2.Old Behavior:
Previously, if the
data
prop was provided, theparams
prop was ignored. This restricted the user's ability to pass additional parameters when reloading the component, leading to a lack of flexibility.New Behavior:
Now, the
params
prop can be used in combination with thedata
prop. This allows users to extend the request parameters beyond the basicdata
specification.Use Case:
Consider the following example:
With this change, both
data
andparams
are processed, ensuring that customparams.data
likelastRoomId
are passed correctly, enabling more flexible and complex reload scenarios.BTW this can resolve my issue here : #2064
Thanks.