Register directives only when Blade is actually needed #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
Thanks so much for creating Inertia. Today, I finally got the chance to try it out.
Everything went smoothly, but something caught my eye in the
ServiceProvider.According to this line in Response, Inertia is only making use of
BladeCompilerfor its very first render. After that, Blade is never touched.However, due to the way things are handled in the
ServiceProvider,BladeCompileris instantiated for every request even when it's not needed. This PR fixes that by leveraging the events provided by the IoC Container.callAfterResolvingis available since Laravel 6, so it's fully backwards compatible.Thanks!