Add CI pipeline + fix multiple env issues #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiodekker
force-pushed
the
ci-improvements
branch
from
5660311 to
21ed435
Compare
claudiodekker
changed the title
PHP 5.4 & 5.5 have reached EOL and are no longer supported by Travis
Laravel 6+ has a minimum version of PHP 7.2
Apply fixes from StyleCI
reinink
reviewed
Sep 30, 2020
…ertia-laravel into ci-improvements
|
Moved testing from Travis CI to Github Actions, which is significantly faster (multiple minutes) 🚀 |
|
Fixed in #220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
This PR drops Laravel 5.8 and earlier, as well as PHP 7.1 and earlier. Below you'll find the reasons why, by going the issues I encountered and their solutions as to show why these changes were necessary.
The first thing I did is to enable TravisCI and StyleCI on all supported PHP and Laravel versions, as to see what would fail. To do this, all that's required is to run the tests against the 'lowest possible' dependency requirements, as well as the most up-to-date ones, on every single PHP version
The first issue that I ran into, is that PHP 5.4 and PHP 5.5 aren't even available on TravisCI anymore, due to already being deprecated a long time ago. This means that we'd also have to drop support for PHP 5.4 and PHP 5.5. Meaning that the lowest possible Laravel version would be 5.6
Once these changes were made, the next issue I ran in to was regarding the 'new' PHPUnit 8+
setUp(): voidsyntax requirement. Basically, this is PHPUnit forcing our hand in using PHPUnit 8.0, which requires PHP 7.1. This lead me to also drop support for PHP 5.6 and 7.0. In addition, this change bumps our minimum version of Laravel up to 5.8, as that one supports both PHPUnit 7.5 and PHPUnit 8Next, after running it again on PHP 7.1, PHPUnit started complaining during runtime that PHPUnit 8 is really only supported with PHP 7.2+ (which was actually also clearly mentioned on their website), meaning we also have to drop PHP 7.1 as well. Luckily, this doesn't mean anything for our minimal Laravel version.
Finally, I ran into an issue with Orchestra's Testbench on Laravel 5.8. Since Laravel 5.8 primarily uses PHPUnit 7.5 (even though it supports PHPUnit 8.0), Testbench went with the PHPUnit 7+ syntax, meaning our PHPUnit 8+ tests will also fail on this version. Because of this Testbench decision / limitation, this also means we have to drop support for Laravel 5.8, making our minimum supported version Laravel 6.
Features:
.gitattributesexport-ignore).editorconfigfor consistent codestyle