rector fixes

.github/workflows/main.yml

@@ -33,6 +33,7 @@ jobs:
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
+          extensions: gd
 
       - name: Get Composer Cache Directory
         id: composer-cache

src/NlpTools/Documents/WordDocument.php

@@ -18,7 +18,7 @@ class WordDocument implements DocumentInterface
 
     protected array $after = [];
 
-    public function __construct(array $tokens, $index, $context)
+    public function __construct(array $tokens, int $index, int $context)
     {
         $this->word = $tokens[$index];
         for ($start = max($index - $context, 0); $start < $index; $start++) {

src/NlpTools/Similarity/Simhash.php

@@ -29,7 +29,7 @@ protected static function md5(string $w): string
         return str_replace(self::$search, self::$replace, md5($w));
     }
 
-    public function __construct(protected int $length, protected $h = 'self::md5')
+    public function __construct(protected int $length, protected $h = [self::class, 'md5'])
     {
     }
 

tests/NlpTools/Clustering/ClusteringTestBase.php

@@ -24,7 +24,7 @@ protected function getColor($t): array
     /**
      * Return a gd handle with a visualization of the clustering or null in case gd is not present.
      */
-    protected function drawClusters(TrainingSet $trainingSet, $clusters, $centroids = null, $lines = false, $emphasize = 0, $w = 300, $h = 200): null|\GdImage|false
+    protected function drawClusters(TrainingSet $trainingSet, $clusters, $centroids = null, $lines = false, $emphasize = 0, $w = 300, $h = 200): mixed
     {
         if (!function_exists('imagecreate')) {
             return null;

tests/NlpTools/Clustering/KmeansTest.php

@@ -9,6 +9,7 @@
 use NlpTools\Documents\EuclideanPoint;
 use NlpTools\Similarity\Euclidean;
 use NlpTools\Clustering\CentroidFactories\Euclidean as EuclidCF;
+use PHPUnit\Framework\Attributes\Group;
 
 class KmeansTest extends ClusteringTestBase
 {
@@ -23,6 +24,7 @@ protected function setUp(): void
         }
     }
 
+    #[Group('Slow')]
     public function testEuclideanClustering(): void
     {
         $kMeans = new KMeans(
@@ -56,7 +58,7 @@ public function testEuclideanClustering(): void
             false // lines or not
         );
 
-        if ($im !== null) {
+        if ($im !== null && $im !== false) {
             imagepng($im, TEST_DATA_DIR . "/Clustering/KmeansTest/clusters.png");
         }
 

tests/NlpTools/Documents/TransformationsTest.php

@@ -9,6 +9,7 @@
 use NlpTools\Documents\TrainingDocument;
 use NlpTools\Documents\WordDocument;
 use PHPUnit\Framework\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class TransformationsTest extends TestCase
 {
@@ -17,9 +18,7 @@ public static function provideTokens(): array
         return [[["1", "2", "3", "4", "5", "6", "7"]]];
     }
 
-    /**
-     * @dataProvider provideTokens
-     */
+    #[DataProvider('provideTokens')]
     public function testTokensDocument(array $tokens): void
     {
         $tokensDocument = new TokensDocument($tokens);
@@ -42,21 +41,19 @@ public function testTokensDocument(array $tokens): void
         );
     }
 
-    /**
-     * @dataProvider provideTokens
-     */
+    #[DataProvider('provideTokens')]
     public function testWordDocument(array $tokens): void
     {
         $identityTransformer = new IdentityTransformer();
-        $wordDocument = new WordDocument($tokens, count($tokens) / 2, 2);
+        $wordDocument = new WordDocument($tokens, (int) (count($tokens) / 2), 2);
         $correct = $wordDocument->getDocumentData();
         $wordDocument->applyTransformation($identityTransformer);
         $this->assertEquals(
             $correct,
             $wordDocument->getDocumentData()
         );
 
-        $trainingDocument = new TrainingDocument("", new WordDocument($tokens, count($tokens) / 2, 2));
+        $trainingDocument = new TrainingDocument("", new WordDocument($tokens, (int) (count($tokens) / 2), 2));
         $trainingDocument->applyTransformation($identityTransformer);
         $this->assertEquals(
             $correct,

tests/NlpTools/Models/LdaTest.php

@@ -10,6 +10,7 @@
 use NlpTools\Documents\TokensDocument;
 use NlpTools\FeatureFactories\DataAsFeatures;
 use PHPUnit\Framework\TestCase;
+use PHPUnit\Framework\Attributes\Group;
 
 /**
  * Functional testing of the Latent Dirichlet Allocation
@@ -63,10 +64,8 @@ protected function setUp(): void
         $this->loadData();
     }
 
-    /**
-     * @group Slow
-     * @group VerySlow
-     */
+    #[Group('Slow')]
+    #[Group('VerySlow')]
     public function testLda(): void
     {
         $lda = new Lda(

tests/NlpTools/Stemmers/PorterStemmerTest.php

@@ -4,6 +4,9 @@
 
 namespace NlpTools\Stemmers;
 
+use NlpTools\Stemmers\PorterStemmer;
+use PHPUnit\Framework\Attributes\Group;
+
 /**
  * Check the correctness of the porter stemmer implementation
  *
@@ -15,9 +18,8 @@ class PorterStemmerTest extends StemmerTestBase
     /**
      * Load a set of words and their stems and check if the stemmer
      * produces the correct stems
-     *
-     * @group Slow
      */
+    #[Group('Slow')]
     public function testStemmer(): void
     {
         $words = new \SplFileObject(TEST_DATA_DIR . '/Stemmers/PorterStemmerTest/words.txt');

tests/NlpTools/Stemmers/TransformationTest.php

@@ -6,6 +6,7 @@
 
 use NlpTools\Documents\TokensDocument;
 use PHPUnit\Framework\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class TransformationTest extends TestCase
 {
@@ -17,9 +18,7 @@ public static function provideStemmers(): array
         ];
     }
 
-    /**
-     * @dataProvider provideStemmers
-     */
+    #[DataProvider('provideStemmers')]
     public function testStemmer(Stemmer $stemmer): void
     {
         $tokens = explode(" ", "this renowned monster who had come off victorious in a hundred fights with his pursuers was an old bull whale of prodigious size and strength from the effect of age or more probably from a freak of nature a singular consequence had resulted he was white as wool");