Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1-pixel wide black line in generated +Y cube face image #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix 1-pixel wide black line in generated +Y cube face image #4

wants to merge 1 commit into from

Conversation

emzo
Copy link

@emzo emzo commented Jul 21, 2022 •
edited
Loading

Fixes #3

There are multiple ways to acheive this in numpy, but this seems to be the most performant. Having said that, I'm no expert with numpy!

indus
indus reviewed Jul 22, 2022
View reviewed changes
Copy link
Owner

@indus indus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I wrong or is the variable view only created but never used?!

@emzo
Copy link
Author

emzo commented Jul 24, 2022

The view variable is just a another view of the ls NumPy array - changes made to view are reflected in ls since they share the same data. It's just easier to add a constant value to each element in the array when you have an array of shape (1,10) rather than (,10) like ls has.

@emzo emzo mentioned this pull request Jul 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indus indus indus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1-pixel wide black line in generated +Y cube face image
2 participants
@emzo @indus