Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prosemirror question type #1131

Merged
merged 12 commits into from
Oct 17, 2024
Merged

Prosemirror question type #1131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
34bc62e
CodeMirrorTextarea: return SafeString from render
inducer Oct 15, 2024
710ea88
Add ProseMirrorTextarea
inducer Oct 15, 2024
977523f
Enforce that pages must inherit from PageBase
inducer Oct 16, 2024
2211f53
Type AttrSpec more precisely
inducer Oct 16, 2024
f6072e7
page.base: More typing, abstract base classes
inducer Oct 16, 2024
0539396
Sandbox: fix YAML expansion
inducer Oct 16, 2024
efaf77a
Sandbox: fix error rendering
inducer Oct 16, 2024
dcf3c4a
Add HumanGradedRichTextQuestion
inducer Oct 16, 2024
baaac13
Use legacy YAML mode in CodeMirror for better highlighting
inducer Oct 16, 2024
2e2629d
Limit page editor height in page sandbox
inducer Oct 16, 2024
546c9a7
Fix dark mode comment color in CodeMirror
inducer Oct 16, 2024
203654e
Codemirror Vim :w comamnd: submit correct form
inducer Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions course/content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1970,6 +1970,10 @@ def instantiate_flow_page(
) -> PageBase:
class_ = get_flow_page_class(repo, page_desc.type, commit_sha)

from course.page.base import PageBase
if not issubclass(class_, PageBase):
raise ClassNotFoundError(f"'{page_desc.type}' is not a PageBase subclass")

return class_(None, location, page_desc)

# }}}
Expand Down
2 changes: 2 additions & 0 deletions course/page/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
from course.page.inline import InlineMultiQuestion
from course.page.static import Page
from course.page.text import (
HumanGradedRichTextQuestion,
HumanGradedTextQuestion,
SurveyTextQuestion,
TextQuestion,
Expand All @@ -55,6 +56,7 @@
"AnswerFeedback",
"ChoiceQuestion",
"FileUploadQuestion",
"HumanGradedRichTextQuestion",
"HumanGradedTextQuestion",
"InlineMultiQuestion",
"InvalidPageData",
Expand Down
Loading