Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode #864

Closed
inducer opened this issue Dec 17, 2021 · 0 comments · Fixed by #1012
Closed

Dark mode #864

inducer opened this issue Dec 17, 2021 · 0 comments · Fixed by #1012
Labels
enhancement

Comments

@inducer
Copy link
Owner

inducer commented Dec 17, 2021

Requested by a student in 450. :)
@inducer inducer mentioned this issue Sep 12, 2023
Merged
3 tasks
inducer added a commit that referenced this issue Sep 3, 2024
@inducer
Fix readonly logic for text/code questions
2ebf73c 
Broken in ea36dc0, part of gh-864.

The gist is that that change reinterpreted read-only as disabled, which
is not true. In django, disabled fields only provide their initial
value, not the bound value. And the DOM will not include them in form
submissions.
@inducer inducer mentioned this issue Sep 3, 2024
Merged
inducer added a commit that referenced this issue Sep 3, 2024
@inducer
Fix readonly logic for text/code questions
44184d9 
Broken in ea36dc0, part of gh-864.

The gist is that that change reinterpreted read-only as disabled, which
is not true. In django, disabled fields only provide their initial
value, not the bound value. And the DOM will not include them in form
submissions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dark mode inducer/relate
1 participant
@inducer