Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - ZWO AM5 Buzzer setup #2087

Merged
merged 4 commits into from
Jul 28, 2024
Merged

Conversation

pawel-soja
Copy link
Contributor

Hello!

I have an AM5 mount and I noticed that the "INDI Control Panel" does not have the ability to change the buzzer volume. The property was not associated with the setBuzzer function and the command was missing the trailing sign (#).

I checked the command by intercepting the transmission from StarGazing.
https://github.com/pawel-soja/ZWO-AM5-Proxy

@pawel-soja pawel-soja requested a review from knro July 27, 2024 19:58
@pawel-soja
Copy link
Contributor Author

The pull request will build correctly after applying #2088 changes. If they are accepted, I can merge to be sure.

I know that drivers are numbered, I can bump the version to setVersion(1, 2); but I think there was also information about the version in some files. I don't remember where what was and whether to change anything. Please advise.

@knro
Copy link
Contributor

knro commented Jul 28, 2024

Yes bumping the version would be great, thanks!

@pawel-soja
Copy link
Contributor Author

I bumped the version to 1.2 in the files:

  • drivers.xml
  • lx200am5.cpp

@knro Is it OK? Will you accept the pull request?

@knro knro merged commit 3fffb79 into indilib:master Jul 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants