Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of myDewControllerPro driver #1855

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Addition of myDewControllerPro driver #1855

merged 4 commits into from
Feb 22, 2023

Conversation

chemistorge
Copy link
Contributor

@chemistorge
Copy link
Contributor Author

Hi,

Once this driver gets added to indiLib, how does Kstars/ekos get updated? For testing i had to manual add an XML file under /usr/share/indi for ekos to see the new driver.

Sorry if this is a silly question but I am new to this contributing and github.

@knro
Copy link
Contributor

knro commented Feb 21, 2023

You can sync your fork or simply rebase to master since your includes actually revert INDI commits. or you can close this PR and re-submit

Copy link
Contributor

@knro knro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to modern INDI convention. Add XML entry to drivers.xml file as well.

drivers/auxiliary/myDewControllerPro.h Outdated Show resolved Hide resolved
drivers/auxiliary/myDewControllerPro.h Outdated Show resolved Hide resolved
drivers/auxiliary/myDewControllerPro.h Outdated Show resolved Hide resolved
drivers/auxiliary/myDewControllerPro.h Outdated Show resolved Hide resolved
drivers/auxiliary/myDewControllerPro.cpp Outdated Show resolved Hide resolved
drivers/auxiliary/myDewControllerPro.cpp Outdated Show resolved Hide resolved
drivers/auxiliary/myDewControllerPro.cpp Outdated Show resolved Hide resolved
drivers/auxiliary/myDewControllerPro.cpp Outdated Show resolved Hide resolved
chemistorge and others added 2 commits February 21, 2023 14:46
Change of INDI properties from legacy to new for myDewControllerPro driver part 1
@chemistorge
Copy link
Contributor Author

All changes made.

@knro knro merged commit 86b6ebd into indilib:master Feb 22, 2023
@chemistorge
Copy link
Contributor Author

chemistorge commented Feb 22, 2023 via email

@knro
Copy link
Contributor

knro commented Feb 23, 2023

It should be in the nightly PPA and should be seen from any client parsing the drivers.xml file. Stable INDI 2.0.1 release is on March 31st.

@chemistorge
Copy link
Contributor Author

chemistorge commented Feb 23, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants