Add InteractionMode property to otp purpose during device authentication #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/device-registration-otp-purpose
|
This fixes the brute force control for otp in device authentcation. The proper solution requires a |
cleftheris
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
It is important to know that the only issue here is not consuming the otp after successful registration. This could be done by creating and maintaining a SecurityStamp on the device record itself that would force the otp to change after the device registration flow completes successfully. At the moment discriminating the purpose is good enough.
On a sidenote the bad request is triggered by a brute force control we have inplace so that for the same purpose we dont spam the sms gateway. It is implemented using a simple cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to differentiate between the 4-pin and biometric purposes during device registration.
Users completing the process in less than 30 seconds are encountering the error:
Last token has not expired yet. Please wait a few seconds and try again.