-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Clone, Debug and documentation for structures #88
Conversation
Clone for: Keys, Values, Iter Debug for: Keys, Values, Iter, Entry Docs for: Keys, Values, Iter, Entry, ValuesMut, IterMut, IntoIter, Drain All copied from HashMap
Clone for: Iter, Difference, Intersection, SymmetricDifference, Union Debug for: Iter, Difference, Intersection, SymmetricDifference, Union Docs for: Iter, Difference, Intersection, SymmetricDifference, Union, IntoIter, Drain All copied from HashSet
These all look good to me, thanks! AFAICS this doesn't affect the minimum supported rustc though, so let's make it 1.0.3 instead of bumping to 1.1. The policy documented in src/lib.rs is to keep consistent for any given 1.x series. |
I don't mind bumping to 1.1 while keeping the same minimum Rust version. Since these are new features, 1.1 seems more correct. |
I tried to study attentively documentation on policy of bumping version and I did not find its any accurate mentioning. The quote from
As from the point of view of the library user I should depend on |
OK, I don't feel strongly about the version, if you're both happy with 1.1. |
ping |
I added Thanks! |
In indexmap-rs/indexmap#88, we found that there was no easy way to implement `Debug` for our `IterMut` and `Drain` iterators. Those are built on `slice::IterMut` and `vec::Drain`, which implement `Debug` themselves, but have no other way to access their data. With a new `as_slice()` method, we can read the data and customize its presentation.
Add as_slice() to slice::IterMut and vec::Drain In indexmap-rs/indexmap#88, we found that there was no easy way to implement `Debug` for our `IterMut` and `Drain` iterators. Those are built on `slice::IterMut` and `vec::Drain`, which implement `Debug` themselves, but have no other way to access their data. With a new `as_slice()` method, we can read the data and customize its presentation.
Add as_slice() to slice::IterMut and vec::Drain In indexmap-rs/indexmap#88, we found that there was no easy way to implement `Debug` for our `IterMut` and `Drain` iterators. Those are built on `slice::IterMut` and `vec::Drain`, which implement `Debug` themselves, but have no other way to access their data. With a new `as_slice()` method, we can read the data and customize its presentation.
Add as_slice() to slice::IterMut and vec::Drain In indexmap-rs/indexmap#88, we found that there was no easy way to implement `Debug` for our `IterMut` and `Drain` iterators. Those are built on `slice::IterMut` and `vec::Drain`, which implement `Debug` themselves, but have no other way to access their data. With a new `as_slice()` method, we can read the data and customize its presentation.
Resolves two cases from #19. I add only trivial implementations -- for example, for
Drain
implementing ofDebug
not trivial, so I do not add it