Skip to content

Commit

Permalink
IWF-472: Skipping test
Browse files Browse the repository at this point in the history
  • Loading branch information
samuel27m committed Jan 27, 2025
1 parent 693dc3b commit 237ea83
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
6 changes: 6 additions & 0 deletions integ/locking_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ import (
)

func TestLockingWorkflowTemporal(t *testing.T) {
// TODO: Remove this line to enable the test
t.Skip("TestLockingWorkflowTemporal - Skipping this test - See: https://github.com/indeedeng/iwf/issues/536")

if !*temporalIntegTest {
t.Skip()
}
Expand All @@ -27,6 +30,9 @@ func TestLockingWorkflowTemporal(t *testing.T) {
}

func TestLockingWorkflowTemporalContinueAsNew(t *testing.T) {
// TODO: Remove this line to enable the test
t.Skip("TestLockingWorkflowTemporal - Skipping this test - See: https://github.com/indeedeng/iwf/issues/536")

if !*temporalIntegTest {
t.Skip()
}
Expand Down
11 changes: 5 additions & 6 deletions integ/workflow/locking/routers.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,11 @@ func (h *handler) ApiV1WorkflowWorkerRpc(c *gin.Context, t *testing.T) {
return
}

// TODO: See issue - https://github.com/indeedeng/iwf/issues/536
//signalChannelInfo := (*req.SignalChannelInfos)[UnusedSignalChannelName]
//if signalChannelInfo.GetSize() != NumUnusedSignals {
// // the 4 messages are sent from the beginning of "locking_test"
// helpers.FailTestWithErrorMessage("incorrect signal channel size", t)
//}
signalChannelInfo := (*req.SignalChannelInfos)[UnusedSignalChannelName]
if signalChannelInfo.GetSize() != NumUnusedSignals {
// the 4 messages are sent from the beginning of "locking_test"
helpers.FailTestWithErrorMessage("incorrect signal channel size", t)
}

if h.rpcInvokes > 0 {
internalChannelInfo := (*req.InternalChannelInfos)[UnusedInternalChannelName]
Expand Down

0 comments on commit 237ea83

Please sign in to comment.