Setup basic window functionality #7
Conversation
ollisco
added
Enhancement🚀
* Initial Cleanup, extract instance creating * fixup im.rs * 🧹 Just sweeping up some unclean code 🧹 * 🧹 Just sweeping some stuff under the rug 🧹 * Oh damn i lost my broom * 🧹 Found it! 🧹 * 📦 Moving stuff around 📦 * Give control flow back to `main` function * Fix error handling * Fix aspect ratio * Remove (not) ppm image generator Co-authored-by: mathiasmagnusson <mathiasmagnussons@gmail.com>
|
I'll write it here as well: I was not quite happy with the current state of I moved some stuff (math redefinitions (so |
| } | ||
|
|
||
| #[derive(Error, Debug)] | ||
| pub enum WindowError { |
There was a problem hiding this comment.
Are we sure we wanna use thiserror here, instead of just anyhow?
There was a problem hiding this comment.
I agree, thiserror is probably overkill
This reverts commit 902e4db. Commit to wrong branch
|
|
||
| use common::{Mat4, Vec3}; | ||
|
|
||
| pub struct Camera { |
There was a problem hiding this comment.
Possibly put this in common?
There was a problem hiding this comment.
I definitly think that we should have some kind of CameraComponent that can be added to an entity (or possibly multiple?) and then the renderer would query for those to know where to render from.
Then the CameraComponent would probably be in common i guess
But of course the renderer would have to know about CameraComponents
|
|
||
| #[rustfmt::skip] | ||
| pub fn opengl_to_wgpu_matrix() -> Mat4 { | ||
| Mat4::new( |
There was a problem hiding this comment.
Maybe comment this? This is black magic, might not be applicable to vek
| } | ||
|
|
||
| pub struct Renderer { | ||
| pub camera: Camera, |
There was a problem hiding this comment.
Feels really scuffed to tie the camera to the renderer, but I don't know how else to do it
Closes #6
Window setup