-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First commit #3
First commit #3
Conversation
Since a lot of code will be shared between the two binary crates I think we should make a cargo workspace in the root folder. This would also sinplify the CI/CD since the whole project can be checked with one command |
Isn't this a one-sided relationship since the IDE imports all of the game engine but the game engine imports nothing? I agree a workspace makes sense just in general, but rather just because it is easier to manage. |
It would probably make our lives easier if we would split the code base up in several library crates (such as ecs, graphics, physics, sound, scripting, etc, and some kind of core that binds most things together) and two binary crates, one which is an IDE/Editor and one used when distibuting a game. The binary crates would (in)directly depend on (almost?) everything and there would be a few dependencies between the library crates. |
Yes I agree if we want to go that route then ofcourse it makes sense. I do like that approach even tho it can become a bit too convoluted at times. I don't think we should use it to an unnecessary degree and generally be taken on a case by case basis. How detailed would we want it to be? Should animating movements etc be a separate crate? Should 3D models be a separate one, should 2D sprites be one(assuming we plan on supporting them? To what degree do we break it down? Maybe seems a bit unneeded to decide right now, but food for thought. |
Like @DreamplaySE said, |
…ect-Delta into ollejer/first-commit
* Rename `game_engine` to `game-engine` * Create cargo workspace; Add `Cargo.lock` to repo * Fix github workflow
Closes #1, #2
This is the first official commit to the project where I added the base crates for the rust development process and GitHub Workflows folder with a base action to check the rust code.
If you have any ideas or opinions, please share them.