Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added phong shading and support for a UI-controlled viewport + other changes #29

Merged
merged 20 commits into from
May 13, 2022
Merged

Added phong shading and support for a UI-controlled viewport + other changes #29

merged 20 commits into from
May 13, 2022

Conversation

TerraDOOM
Copy link
Collaborator

@TerraDOOM TerraDOOM commented May 4, 2022 •
edited
Loading

  • Added Phong shading (or at least the ambient/diffuse components of it) using vertex normals.
  • Added deferred rendering and proper point light support (with light volumes)
  • Added support for a UI-controlled viewport
  • Modified Renderer to compartmentalize the actual drawing into its own World struct that can be duplicated etc.
  • Changed the ModelManager to instead be effectively a writable "guard" for the backing GPU-buffers, so that on drop all pending changes are automatically flushed to the GPU.
  • Fixed a bug where vertex/index buffers were overwritten with new data before the draws were actually performed, resulting in the final draw using vastly wrong vertex and index data.

Closes #18
Closes #30

TerraDOOM added 10 commits March 28, 2022 14:30
@TerraDOOM
Initial egui commit
1b5cb5d
@TerraDOOM
Fixed warnings
c48e26f
@TerraDOOM
Commented rendering code
9d6dbc3 
Added comments to a bunch of the rendering code to hopefully explain what it's doing.
@TerraDOOM
Fixed ball.obj to have smooth normals
3e40993
@TerraDOOM
Major changes
2030369 
- Added basic phong shading using vertex normals
- Added basic traits to Camera
- Added normal maps to Material (so far unused)
- Added logic to create custom render targets that can be rendered to
- Factored out much of the rendering logic into a new "World" struct
  which can be duplicated and have their own custom render targets, this
  to facilitate rendering a scene to a texture for use in egui.
- Refactored the clip rect logic
- Added resize logic to the painter
@TerraDOOM
Changed some ide error handling
9ff4537
@TerraDOOM
Made changes to the ModelManager
fecdb6a 
Updated the ModelManager to use a pattern similar to a MutexGuard, in
that it freely allows writing to the instances, and uses a Drop impl to
synchronize the values to the GPU.
@TerraDOOM
Updated Cargo.lock
c20addd
@TerraDOOM
Added viewports and fixed improper egui rendering
952aa6b
@TerraDOOM
Fixed warnings
f1896eb
@foodelevator foodelevator added the Renderer✒️ This is related to the renderer label May 4, 2022
@TerraDOOM TerraDOOM marked this pull request as ready for review May 13, 2022 14:11
foodelevator
foodelevator approved these changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@foodelevator foodelevator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's amazing

@TerraDOOM TerraDOOM merged commit c6a622a into main May 13, 2022
@foodelevator foodelevator deleted the shading-and-egui branch May 13, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foodelevator foodelevator foodelevator approved these changes

@VincentLagerros VincentLagerros VincentLagerros approved these changes

Assignees
No one assigned
Labels
Renderer✒️ This is related to the renderer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add customizable light sources Engine asset management
3 participants
@TerraDOOM @foodelevator @VincentLagerros