Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS - Command Buffers #28

Merged
merged 19 commits into from
May 13, 2022
Merged

ECS - Command Buffers #28

merged 19 commits into from
May 13, 2022

Conversation

foodelevator
Copy link
Collaborator

@foodelevator foodelevator commented May 3, 2022

Add a way to buffer some actions to be performed on the World at a later stage when possible.

This will make it possible to for example remove certain entities while looping over them.

Todo:

  • Command to spawn & despawn entities
  • Command to add components to entities
  • Add a way to add components to newly spawned entities
  • Add a way to get a handle to the new Entity being spawned

@foodelevator foodelevator added the ECS🏴󠁥󠁣󠁳󠁿 Relatet to the Entity Compnent System label May 4, 2022
@foodelevator foodelevator force-pushed the ecs/command-buffers branch from 8c5d283 to b273e3f Compare May 9, 2022 15:12
@foodelevator
Copy link
Collaborator Author

foodelevator commented May 9, 2022

The current API when creating a Commands is not very nice, but there were some borrow checking problems that had to be solved.

@foodelevator foodelevator marked this pull request as ready for review May 9, 2022 15:33
@foodelevator foodelevator force-pushed the ecs/command-buffers branch from 6ce3305 to e0dfc98 Compare May 9, 2022 18:42
@foodelevator foodelevator force-pushed the ecs/command-buffers branch from 3e6d937 to 2c267ef Compare May 9, 2022 19:09
ollisco
ollisco previously approved these changes May 9, 2022
Copy link
Collaborator

@ollisco ollisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand it but it looks good

@foodelevator foodelevator changed the title Ecs - Command Buffers ECS - Command Buffers May 13, 2022
Copy link
Collaborator

@TerraDOOM TerraDOOM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sketchy but it works

Copy link
Collaborator

@TerraDOOM TerraDOOM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops

@foodelevator foodelevator merged commit 5bfe6f6 into main May 13, 2022
@foodelevator foodelevator deleted the ecs/command-buffers branch May 13, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ECS🏴󠁥󠁣󠁳󠁿 Relatet to the Entity Compnent System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants