Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recompute Z from P when Z is infinity #39

Merged
merged 1 commit into from
Jul 23, 2018
Merged

Recompute Z from P when Z is infinity #39

merged 1 commit into from
Jul 23, 2018

Conversation

cmaumet
Copy link
Member

@cmaumet cmaumet commented Jul 20, 2018

This PR updates the NIDM SPM viewer to:

  • recompute the equivalent Z from the P-value when Z=infinity in the NIDM pack.

@cmaumet cmaumet requested a review from TomMaullin July 20, 2018 11:24
@cmaumet cmaumet changed the title When Z value is infinity try recomputing from P Recompute Z from P when Z is infinity Jul 20, 2018
@TomMaullin
Copy link
Collaborator

TomMaullin commented Jul 23, 2018 •
edited
Loading

Hi @cmaumet ,

This looks good to me! These edits seem fairly straightforward - I can't think of any feedback to improve them! I'm happy to merge when you are! Just out of curiosity... I was just wondering do you know what the cause of the Inf's in the NIDM exporters are?

@cmaumet
Copy link
Member Author

cmaumet commented Jul 23, 2018 •
edited
Loading

Thanks @TomMaullin! Let's merge. The Inf are generated by SPM: https://github.com/spm/spm12/blob/master/spm_list.m#L464-L470. This fix could also be included in the NIDM exporter but there might be a good reason for this behaviour. Let's check with @gllmflndn first.

@cmaumet cmaumet merged commit aa74242 into incf-nidash:master Jul 23, 2018
@cmaumet cmaumet deleted the fix_inf branch July 23, 2018 12:00
@cmaumet cmaumet mentioned this pull request Jul 23, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomMaullin TomMaullin Awaiting requested review from TomMaullin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaumet @TomMaullin