Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4430 -Highlight rows may get merged in PDF editor at high scale factors #4431

Conversation

reckart
Copy link
Member

@reckart reckart commented Jan 6, 2024

What's in the PR

  • Remove the scale factor from the merge margin calculation to fix the issue
  • Improve border and selection marker widths as scale factor increases (i.e. do not scale them along linarly)
  • Make the border and selection marker a bit more transparent so text is better readable

How to test manually

  • See issue description / play around with different scale factors in PDF editor

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Remove the scale factor from the merge margin calculation to fix the issue
- Improve border and selection marker widths as scale factor increases (i.e. do not scale them along linarly)
- Make the border and selection marker a bit more transparent so text is better readable
@reckart reckart added 🐛 Bug Something isn't working Module: PDF editor labels Jan 6, 2024
@reckart reckart added this to the 30.2 milestone Jan 6, 2024
@reckart reckart self-assigned this Jan 6, 2024
@reckart reckart merged commit 3d2c04e into release/30.x Jan 6, 2024
2 checks passed
@reckart reckart deleted the bugfix/4430-Highlight-rows-may-get-merged-in-PDF-editor-at-high-scale-factors branch January 6, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working Module: PDF editor
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant