-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add function read_raster_runif #136
Conversation
The rgdal proj4string degradation warnings are applicable. Also, they will disappear in the future, so unneeded to add specific code. It should be up to the user to cope with these warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for preparing the function @ToonHub! Nice work.
I propose some small updates in PR #138, where I suggest to drop suppressWarnings()
because those warnings are not irrelevant to the user (a proj4string for EPSG:31370
is included in the returned object but it is degraded and should not be used). Instead, a package startup message has been created to give some advice. The rgdal
warnings are expected to go away in the future.
read_raster_runif(): updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes #134.
Any comments on my proposed pkg startup message? @ToonHub @cecileherr or others? > library(n2khab)
Attaching n2khab version 0.4.0.9000.
When working with raster objects returned by n2khab, you can safely
mute proj4string degradation warnings:
options(rgdal_show_exportToProj4_warnings = "none")
You must do this before using the n2khab functions depending on
rgdal or raster, and before loading the latter (or sp).
Do note that those warnings are applicable: the generated proj4string
of 'EPSG:31370' objects is effectively degraded and should not be used.
See https://inbo.github.io/n2khab/#suppressing-rgdal-warnings-about-proj4string-degradation
for more information. |
Good idea to mention this.
Is the sentence above correct? I do not really understand what you mean. |
Your question is reason enough to improve it 😉. Suggestion:
Is this more clear? 'is degraded' refers to 'the proj4string' |
Or:
|
OK. It is more clear now. |
I'll add an updated message here, thanks. @ToonHub I also suggest not to include the version and directory specific reference to the n2khab-preprocessing repo. It is done at Zenodo, but there it is for specific data source versions. Here I'd strive to minimal future maintenance of documentation (version independence, directory independence). I'll update according to the approach in other functions. |
I added the function read_raster_runif.