Left trim optional spaces in event field values #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbrujohalcon
requested changes
Mar 9, 2020
|
@elbrujohalcon thanks for feedback and patience. I added some event parsing unit tests in 3d9ea47. How does that look? |
elbrujohalcon
approved these changes
Mar 30, 2020
test/shotgun_unit_SUITE.erl
Outdated
Comment on lines
28
to
45
| -spec init_per_suite(shotgun_test_utils:config()) -> | ||
| shotgun_test_utils:config(). | ||
| init_per_suite(Config) -> | ||
| Config. | ||
|
|
||
| -spec end_per_suite(shotgun_test_utils:config()) -> shotgun_test_utils:config(). | ||
| end_per_suite(Config) -> | ||
| Config. | ||
|
|
||
| -spec init_per_testcase(atom(), shotgun_test_utils:config()) -> | ||
| shotgun_test_utils:config(). | ||
| init_per_testcase(_, Config) -> | ||
| Config. | ||
|
|
||
| -spec end_per_testcase(atom(), shotgun_test_utils:config()) -> | ||
| shotgun_test_utils:config(). | ||
| end_per_testcase(_, Config) -> | ||
| Config. |
There was a problem hiding this comment.
These are all optional and they're not doing anything at all in this case. I would recommend just removing them.
There was a problem hiding this comment.
Right of course, removed in 3a243ff. Thanks.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSE spec says that space(s) after a
:when parsing event stream are optional. Currentlyshotgunrequires one space. Here I trim these insignificant spaces to be compatible with the spec. SSE tests still pass becauselasseappears to always send that optional space.