Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to stable gun, fix tests #174

Merged
merged 4 commits into from
Oct 12, 2018

Conversation

unix1
Copy link
Contributor

@unix1 unix1 commented Oct 12, 2018

This PR updates shotgun to stable gun 1.3.0. It also updates lasse and cowboy test dependencies to their corresponding stable versions, and fixes #173 so that all existing tests pass.

Notes:

  • I don't have xref set up, so I can't tell if that (still) works
  • I haven't done any real world testing, just made all current test pass with updated dependencies

unix1 added 4 commits October 11, 2018 23:02
- gun updated to 1.3.0
- cowboy updated to 2.4.0
- lasse updated to 1.2.0
- fix test so cowboy starts
- other minor fixes so tests run
@elbrujohalcon
Copy link
Member

Amazing, thanks @unix1 !! :)

@elbrujohalcon elbrujohalcon merged commit 63fc789 into inaka:master Oct 12, 2018
@unix1 unix1 deleted the upgrade-to-stable-gun branch October 12, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing
2 participants