Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dave.151.update.deps.to.2.0.0.pre #152

Merged
merged 4 commits into from
Jun 7, 2016

Conversation

davecaos
Copy link
Contributor

@davecaos davecaos commented Apr 1, 2016

This PR depends that inaka/lasse#44 it will previously merged

Handler = case Method of
<<"HEAD">> -> handle_head;
_ -> handle_get
end,
{[{<<"text/plain">>, Handler}], Req1, State}.
ct:pal("Method ~p , Handler ~p", [Method,Handler ]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Elvis:

Missing space right "," on line 23

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Elvis:

Remove the debug call to ct:pal/2 on line 23.

@davecaos davecaos force-pushed the dave.151.update.deps.to.2.0.0.pre branch 2 times, most recently from aa490ba to 12fa882 Compare April 1, 2016 19:15
@davecaos davecaos force-pushed the dave.151.update.deps.to.2.0.0.pre branch from 12fa882 to 50fd396 Compare April 1, 2016 20:31
@davecaos davecaos force-pushed the dave.151.update.deps.to.2.0.0.pre branch from c8e27ea to 3bbf3c8 Compare April 13, 2016 21:50
@Euen Euen removed the WIP label Jun 7, 2016
dep_cowlib = hex 1.0.2
dep_gun = hex 1.0.0-pre.1

dep_gun = git https://github.com/ninenines/gun.git d88f3675d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a main dep (i.e. it's in DEPS). It should be fetched from hex

@elbrujohalcon elbrujohalcon reopened this Jun 7, 2016
@elbrujohalcon elbrujohalcon merged commit 489ab2a into master Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants