Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type of shotgun response #168

Closed
Euen opened this issue May 2, 2017 · 7 comments · Fixed by #187
Closed

Update type of shotgun response #168

Euen opened this issue May 2, 2017 · 7 comments · Fixed by #187
Assignees

Comments

@Euen
Copy link
Member

Euen commented May 2, 2017

Change

-type headers()    :: #{} | proplists:proplist().
-type response() :: #{ status_code => integer()
                     , header => map()
                     , body => binary()
                     }.

to

-type headers()    :: #{} | proplists:proplist().
-type response() :: #{ status_code => integer()
                     , headers => headers()
                     , body => binary()
                     }.

in shotgun.erl

@Euen Euen self-assigned this May 2, 2017
Euen added a commit that referenced this issue May 2, 2017
Euen added a commit that referenced this issue May 4, 2017
@mworrell
Copy link
Collaborator

mworrell commented Sep 1, 2021

Can this please be corrected to the headers type?
Now we have problems passing dialyzer tests.

@elbrujohalcon
Copy link
Member

Sure, do you mind sending a PR, @mworrell ?

@mworrell
Copy link
Collaborator

mworrell commented Sep 2, 2021

@elbrujohalcon Sure, see #187

@mworrell
Copy link
Collaborator

mworrell commented Sep 2, 2021

wow, you are fast!

@mworrell
Copy link
Collaborator

mworrell commented Sep 2, 2021

Do you know when the next Hex release is scheduled?
Then I know when I can finalize our depending changes.

@elbrujohalcon
Copy link
Member

@mworrell
Copy link
Collaborator

mworrell commented Sep 2, 2021

Thanks! This is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants