Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in specs #257

Merged
merged 2 commits into from
Aug 26, 2015
Merged

Fix typo in specs #257

merged 2 commits into from
Aug 26, 2015

Conversation

NOMORECOFFEE
Copy link
Contributor

  • fix target type elvis:rock_this
  • change spec in elvis_utils:erlang_halt to no_return()

@NOMORECOFFEE
Fix typo in specs
6d59585 
* fix target type elvis:rock_this
* change spec in elvis_utils:erlang_halt to no_return()
@jfacorro
Copy link
Contributor

@NOMORECOFFEE Thanks for fixing those spec! Would it be possible for you to correct the @doc string for the elvis_utils:erlang_halt/0 function? It already had a few typos 😞 and we missed them. It would only involve adding a few letter 😛 here, replacing this:

%% @doc This is defined so tht it an be mocked for tests.

For this:

%% @doc This is defined so that it can be mocked for tests.

Thanks!

jfacorro added a commit that referenced this pull request Aug 26, 2015
@jfacorro
Merge pull request #257 from NOMORECOFFEE/master
e2c243d 
Fix typo in specs
@jfacorro jfacorro merged commit e2c243d into inaka:master Aug 26, 2015
@jfacorro
Copy link
Contributor

@NOMORECOFFEE Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NOMORECOFFEE @jfacorro