Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY #28

Closed
elbrujohalcon opened this issue Jun 26, 2014 · 1 comment
Closed

DRY #28

elbrujohalcon opened this issue Jun 26, 2014 · 1 comment
Assignees
@jfacorro
Labels
rule
Milestone
0.3.0 - With MORE...

Comments

@elbrujohalcon
Copy link
Member

Rule

don't repeat yourself

Implementation

Find exactly the same code repeated in the same module
@elbrujohalcon elbrujohalcon added this to the 1.1.0 - With MORE rulez milestone Jun 26, 2014
jfacorro added a commit that referenced this issue Apr 23, 2015
@jfacorro
[#28] Created function to remove location attribute from all nodes
8e58350
jfacorro added a commit that referenced this issue Apr 24, 2015
@jfacorro
[#28] Working implementation of DRY
718f943
jfacorro added a commit that referenced this issue Apr 24, 2015
@jfacorro
[#28] Added min_complexity option
219bc4e
jfacorro added a commit that referenced this issue Apr 24, 2015
@jfacorro
[#28] Improve output of DRY rule. Fix bug for nodes without node_attrs.
c33cfe7
jfacorro added a commit that referenced this issue Apr 25, 2015
@jfacorro
[#28] Added tests. Fixed bugs
6b55bfc
jfacorro added a commit that referenced this issue Apr 25, 2015
@jfacorro
[#28] Improved implementation from O(N^2) to O(N)
3249e36
jfacorro added a commit that referenced this issue Apr 25, 2015
@jfacorro
[#28] Renamed fold/3 to edit_all/3 and implemented real fold/3
d182e60
jfacorro added a commit that referenced this issue Apr 25, 2015
@jfacorro
[#28] Filter out nodes that are children of other results
02a8db1
jfacorro added a commit that referenced this issue Apr 26, 2015
@jfacorro
[#28] Added successful file to tests
0e4cb14
jfacorro added a commit that referenced this issue Apr 26, 2015
@jfacorro
[#28] Added ignore module for test of module_naming_convention
b8b2745
jfacorro added a commit that referenced this issue Apr 26, 2015
@jfacorro
[#28] Change escript target back to its original state
8c313b2
@jfacorro jfacorro mentioned this issue Apr 26, 2015
Merged
@jfacorro jfacorro self-assigned this Apr 26, 2015
jfacorro added a commit that referenced this issue Apr 26, 2015
@jfacorro
[#28] Moved functions to zipper library and opened inaka/zipper#16
68a5b71
igaray added a commit that referenced this issue Apr 27, 2015
@igaray
Merge pull request #218 from inaka/jfacorro.28.dry
1422a9a 
WIP [#28] DRY rule
jfacorro added a commit that referenced this issue Apr 27, 2015
@jfacorro
[#28] Updated zipper functions after renaming edit_all to fmap
ba1b3b9
@jfacorro jfacorro mentioned this issue Apr 27, 2015
Merged
igaray added a commit that referenced this issue Apr 27, 2015
@igaray
Merge pull request #220 from inaka/jfacorro.28.dry
18317a7 
[#28] Updated zipper functions after renaming edit_all to fmap
@jfacorro
Copy link
Contributor

Closed by #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfacorro jfacorro

Labels
rule
Projects
None yet
Milestone
0.3.0 - With MORE rulez
Development

No branches or pull requests
2 participants
@elbrujohalcon @jfacorro