Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags to continue on errors #570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add flags to continue on errors #570

wants to merge 1 commit into from
+655 −219

Conversation

colek42
Copy link
Member

@colek42 colek42 commented Mar 21, 2025 •
edited
Loading

Summary

  • Add flags to handle errors gracefully and continue execution when the wrapped command succeeds
  • Implements a new error types system for proper error classification and handling
  • Fix string-based error detection with robust type-based detection
  • Add comprehensive unit tests for error types and error handling

Test plan

  • Run tests for the new error types and classification system
  • Test different error scenarios with various flag combinations
  • Verify that the error handling behaves correctly with multiple levels of error wrapping

@netlify Netlify
Copy link

netlify bot commented Mar 21, 2025 •
edited
Loading

✅ Deploy Preview for witness-project ready!

Name Link
🔨 Latest commit 33873f0
🔍 Latest deploy log https://app.netlify.com/sites/witness-project/deploys/67dec3f6d0b078000815f31e
😎 Deploy Preview https://deploy-preview-570--witness-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colek42 colek42 force-pushed the feature/continue-on-errors branch 4 times, most recently from 490d3c7 to 8f6cbe9 Compare March 22, 2025 14:04
feat: add continue-on-error flags with robust error handling
33873f0 
- Add flags to continue execution when the wrapped command succeeds:
  - --continue-on-attestor-error for attestor-related errors
  - --continue-on-infra-error for infrastructure errors
  - --continue-on-errors for both error types
- Create proper error type system for error classification
- Implement robust error type detection and propagation
- Improve error handling throughout command execution
- Add comprehensive unit tests for error handling

Signed-off-by: Cole Kennedy <cole@testifysec.com>
@colek42 colek42 force-pushed the feature/continue-on-errors branch from 8f6cbe9 to 33873f0 Compare March 22, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@colek42