Clean up InTotoVerify and rsa public key loading #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,29 @@ import ( | |||
| "reflect" | |||
| ) | |||
|
|
|||
| func ParseRSAPublicKeyFromPEM(pemBytes []byte) (*rsa.PublicKey, error) { | |||
| // TODO: There could be more key data in _, which we silently ignore here. | |||
| // Should we handle it / fail / say something about it? | |||
There was a problem hiding this comment.
If we were to merge this, could we ticketize this issue?
in_toto/model.go
Outdated
| @@ -68,6 +68,27 @@ type Layout struct { | |||
| Readme string `json:"readme"` | |||
| } | |||
|
|
|||
| // Go does not allow to pass `[]T` (slice with certain type) to a function | |||
| // the accepts `[]interface{}` (slice with generic type) | |||
| inspectionsI[i] = v | ||
| } | ||
| return inspectionsI | ||
| } |
There was a problem hiding this comment.
Aside: is this just another instance of lolnogenerics?
Steps and inspections (supply chain items) share some common fields that used to be defined redundantly before. This commit adds a new struct `SupplyChainItem` that defines the common fields, and adds SupplyChainItem as anonymous field to the Step and Inspection struct definitions (which is akin to inheritance).
Move two type conversion loops out of InTotoVerify, into two new layout helper. See code comments for reasoning.
Create helper function to reuse rsa public key parsing functionality that used to be implemented in both VerifySignature and LoadPublicKey.
|
@SantiagoTorres, thanks for your review! I addressed you comments, except for the one about lolnogenerics, I fear I can't fix that one. :P I also had to quickly fix the test layout expiration (#15) and rebase. |
|
Thanks @lukpueh ! |
This was referenced Jan 9, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a few small code refactors for clean up: