Fix warnings detected in upcoming toolchains #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.80 will warn if a package uses a cfg that it doesn't know about
[1]. We can teach the compiler about our custom board, family, and chip
configurations in our build scripts.
Tested against a nightly 1.80 toolchain with the following commands:
cargo +nightly build --package=imxrt-hal --features=imxrt-ral/imxrt1062,imxrt1060
cargo +nightly build --package=imxrt-log --features=imxrt-hal/imxrt1060,imxrt-ral/imxrt1062
cargo +nightly build --package=board --features=board/teensy4
Re-run those commands without this commit, and observe warnings
describing missing configurations.
[1]: https://blog.rust-lang.org/2024/05/06/check-cfg.html
teburd
approved these changes
May 10, 2024
|
neat feature, for checking features :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future Rust toolchains will warn about unknown cfgs and introduce more clippy warnings. This PR eagerly fixes those warnings. See commits for more information.