Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle BOM prefix in package.json #9

Merged
merged 1 commit into from
Jul 9, 2020
Merged

fix: handle BOM prefix in package.json #9

merged 1 commit into from
Jul 9, 2020

Conversation

antongolub
Copy link
Contributor

Hi there.

Caught an exception while parsing paralleljs package.json. It contains BOM prefix, so it just needs to be removed.
Similar issue: bazel-contrib/rules_nodejs#1448

Unexpected token  in JSON at position 0

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 280d21d on antongolub:fix_bom into a81a044 on imsnif:master.

@antongolub antongolub mentioned this pull request Jul 8, 2020
Merged
imsnif
imsnif approved these changes Jul 9, 2020
View reviewed changes
Copy link
Owner

@imsnif imsnif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@imsnif imsnif merged commit 5a50d5b into imsnif:master Jul 9, 2020
@antongolub antongolub deleted the fix_bom branch July 9, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imsnif imsnif imsnif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antongolub @coveralls @imsnif