-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JoSS Review: Repository #22
Labels
review comment
JOSS reviewer comment
Comments
Nishika Girish was a high school intern at Columbia during which time she
designed the google forms for tutorials and feedback.
She also collected feedback from local MR users at Columbia for refining
features. Her contribution trail can also be seen on the issues she has
reported.
Tommy Vaughan has been principally involved in designing accessible MRI
tools such as the virtual scanner, mentored the developers with scientific
inputs during weekly meetings in addition to reviewing the outcomes.
…On Fri, Aug 9, 2019 at 1:50 PM Vanessasaurus ***@***.***> wrote:
Repository
This is for openjournals/joss-reviews#1637
<openjournals/joss-reviews#1637>
I can confirm that the repository, here, does in fact exist, and has
instructions for contribution (CONTRIBUTING.md) along with a
CODE_OF_CONDUCT.md. The LICENSE file is an OSI approved license, and
version 1.0.0 matches what is submit with the paper.
For Authors, I can match the paper authors as follows (please correct me
if I mess up)
- Gehua Tong1: https://github.com/tonggehua
- Sairam Geethanath1: https://github.com/sairamgeethanath
- Marina Jimeno Manso1: https://github.com/Mmj94 ?
- Enlin Qian1: https://github.com/qianenlin
- Keerthi Sravan Ravi1: https://github.com/sravan953
- Nishika Girish2
- John Thomas Vaughan Jr.
I don't see GitHub aliases for the last 2, associated with the code - the
remaining one is for the org (imr-framework)
and the contributions are tiny. Could you clarify the contributions of the
last two authors, if they did not work on the software directly?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#22?email_source=notifications&email_token=AHLQWAJXL7YOY5RQ7WQCIM3QDWU7JA5CNFSM4IKWDPO2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HEOPMCQ>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHLQWAKF2E3N7VE5PMVGLHLQDWU7JANCNFSM4IKWDPOQ>
.
--
*Sairam Geethanath, Ph.D.*
“There are plenty of compelling reasons to push MRI to be more powerful,
but that’s one facet of advancing the field. Another is delivering it to
the world.”
|
Great, thanks for the clarification! Both of those contributions are very much appropriate to warrant authorship. Nishika will probably be very excited to have her name on a paper! The repository looks good for the points above, closing issue. |
Closed
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Repository
This is for openjournals/joss-reviews#1637
I can confirm that the repository, here, does in fact exist, and has instructions for contribution (CONTRIBUTING.md) along with a CODE_OF_CONDUCT.md. The LICENSE file is an OSI approved license, and version 1.0.0 matches what is submit with the paper.
For Authors, I can match the paper authors as follows (please correct me if I mess up)
I don't see GitHub aliases for the last 2, associated with the code - the remaining one is for the org (imr-framework) and the contributions are tiny. Could you clarify the contributions of the last two authors, if they did not work on the software directly?
The text was updated successfully, but these errors were encountered: