Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JoSS Review: Repository #22

Closed
vsoch opened this issue Aug 9, 2019 · 2 comments
Closed

JoSS Review: Repository #22

vsoch opened this issue Aug 9, 2019 · 2 comments
Labels
review comment JOSS reviewer comment

Comments

@vsoch
Copy link
Contributor

vsoch commented Aug 9, 2019

Repository

This is for openjournals/joss-reviews#1637

I can confirm that the repository, here, does in fact exist, and has instructions for contribution (CONTRIBUTING.md) along with a CODE_OF_CONDUCT.md. The LICENSE file is an OSI approved license, and version 1.0.0 matches what is submit with the paper.

For Authors, I can match the paper authors as follows (please correct me if I mess up)

I don't see GitHub aliases for the last 2, associated with the code - the remaining one is for the org (imr-framework) and the contributions are tiny. Could you clarify the contributions of the last two authors, if they did not work on the software directly?

@sairamgeethanath
Copy link
Collaborator

sairamgeethanath commented Aug 9, 2019 via email

@vsoch
Copy link
Contributor Author

vsoch commented Aug 9, 2019

Great, thanks for the clarification! Both of those contributions are very much appropriate to warrant authorship. Nishika will probably be very excited to have her name on a paper! The repository looks good for the points above, closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review comment JOSS reviewer comment
Projects
None yet
Development

No branches or pull requests

2 participants