Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOS app for the PDA #1450

Merged
merged 12 commits into from
Jan 22, 2025
Merged

SOS app for the PDA #1450

merged 12 commits into from
Jan 22, 2025

Conversation

Saeko-44
Copy link

Changelog

🆑

  • add: SOS app for the PDA

Copy link

@Darkmajia Darkmajia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

havent tested it in-game yet but i wanna be a little nitpicky if you will allow me. also, the location isnt announced? i guess the intention is that the warden is supposed to watch the crew monitor

@ruddygreat
Copy link

ruddygreat commented Jan 21, 2025

should add at least a doafter to actually sending the message, w/o a cooldown it's incredibly easy to render sec comms unusable.
has a side-benefit of letting antags know when johnny bartender is trying to SOS out of the saw trap they've set up, could even be really mean and make the doafter interruptible.

@Pinkbat5
Copy link

Pinkbat5 commented Jan 21, 2025

Glad to see someone implementing this, though it needs "call engineering/medical" options and a location broadcast before I'd consider it good enough to replace greencomms

@kipdotnet
Copy link

should add at least a doafter to actually sending the message, w/o a cooldown it's incredibly easy to render sec comms unusable. has a side-benefit of letting antags know when johnny bartender is trying to SOS out of the saw trap they've set up, could even be really mean and make the doafter interruptible.

Having to fumble with the stupid broken PDA interface is enough of a timesink imo. That shit barely works at the best of times

@honeyed-lemons
Copy link

My opinion on this is to make it part of the headset, and not the pda. PDAs are finicky, and it won’t be fun fumbling with it when you’re being attacked. Just a context menu click on your headset is enough for me

@Saeko-44
Copy link
Author

Glad to see someone implementing this, though it needs "call engineering/medical" options and a location broadcast before I'd consider it good enough to replace greencomms

The SOS component calls security by default but you could declare other cartridges that calls for help from any other communication channel by specifying the HelpChannel on the yml declaring it. No cs code needed.

As for the location, this is purposefully not implemented as to keep coordinates and the crew monitor relevant

@Saeko-44
Copy link
Author

My opinion on this is to make it part of the headset, and not the pda. PDAs are finicky, and it won’t be fun fumbling with it when you’re being attacked. Just a context menu click on your headset is enough for me

Your headset should not magically have access to the security channel when youre endangered. PDA makes way more sense.

@Saeko-44
Copy link
Author

should add at least a doafter to actually sending the message, w/o a cooldown it's incredibly easy to render sec comms unusable. has a side-benefit of letting antags know when johnny bartender is trying to SOS out of the saw trap they've set up, could even be really mean and make the doafter interruptible.

Thats implemented now

@Saeko-44
Copy link
Author

Having to fumble with the stupid broken PDA interface is enough of a timesink imo. That shit barely works at the best of times

I could add a contextual action the same way the PDA flashlight toggle is, but also, I dont think you should be able to call for help that easily. Like think about it. If irl a serial killer broke into your house you would still have to fumble with your stupid phone interface if you want to have any chance of being rescued. Its part of the fun.

@kipdotnet
Copy link

How long is the doafter? Going from typing ";HELP SCIENCE" to "open inventory > wait for pda UI to load > press button > perform doafter > not even send a location" sounds like a pain in the ass thatll probably never be able to be managed in a situation where you need immediate help

@hivehum
Copy link

hivehum commented Jan 21, 2025

it needs the doafter/cooldown.

Content.client_2025.01.21_-_13.48.05.01.mp4

@Saeko-44
Copy link
Author

How long is the doafter? Going from typing ";HELP SCIENCE" to "open inventory > wait for pda UI to load > press button > perform doafter > not even send a location" sounds like a pain in the ass thatll probably never be able to be managed in a situation where you need immediate help

This is part of the features mira requested as part of the greencomms removal so the alternative isnt ;help science its either your department radio and hoping someone relays the message or just successfully running away

@Saeko-44
Copy link
Author

it needs the doafter/cooldown.
Content.client_2025.01.21_-_13.48.05.01.mp4

The cooldown has been implemented as of commit 329aab3. I think you're just out of date

@hivehum
Copy link

hivehum commented Jan 22, 2025

The cooldown has been implemented as of commit 329aab3. I think you're just out of date

not my video, its ruddygreats, i was posting in response to kip saying that the doafter isnt necessary

@kipdotnet
Copy link

The cooldown has been implemented as of commit 329aab3. I think you're just out of date

not my video, its ruddygreats, i was posting in response to kip saying that the doafter isnt necessary

Im aware it needs a cooldown, I specifically said doafter as in having to press the button and wait 10 seconds for a meter to fill up while not being able to perform any other action and breaking if you take damage

@Saeko-44
Copy link
Author

The cooldown has been implemented as of commit 329aab3. I think you're just out of date

not my video, its ruddygreats, i was posting in response to kip saying that the doafter isnt necessary

Im aware it needs a cooldown, I specifically said doafter as in having to press the button and wait 10 seconds for a meter to fill up while not being able to perform any other action and breaking if you take damage

I think thats overkill but ultimately thats up to mira since she requested the feature

Copy link

@mqole mqole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future would love some user feedback for the cooldown, eg. a timer that shows how long a user has to wait to repeat the button press. pda ui is janky though so i wont ask for that to be part of this pr. looks gud

theres been some discussion on this one but i think we just need to playtest and see how it feels. can revert if bad

@mqole mqole merged commit 162e52a into impstation:master Jan 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants