Vox sounds!!! #1448
Merged
Vox sounds!!! #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit af99967.
mqole
requested changes
Jan 22, 2025
There was a problem hiding this comment.
implementation looks good! just some minor notation stuff.
this is also super pedantic but there are some audio files that havent been tailed (they just kinda cut off abruptly), and voxcry1... doesnt really sound like a cry emote to me?
happy to elaborate and/or tweak where needed, hmu on discord o7
|
Oh yeah, easy fixes. The cutoff is from the pitch going down too far lol, but yeah I can bonk that out real quick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brand new bird sounds for our wonderful birb aliens!
2025-01-20.23-17-59.mp4
🆑