Return of clown waddling

[DinnerCalzone]

Reimplements clown waddling with a fix from a closed PR from upstream (space-wizards#29341) that makes it so the animation system properly checks when you should not be waddling. Additionally, I have modified the WaddleWhenWorn component to work off of a toggle, allowing you to control waddling on-demand. This affects clown shoes, large clown shoes, bling clown shoes, banana clown shoes, jester shoes, circus clown shoes, ducky shoes, and cluwne shoes.

I've made a _Wizden folder for the components and systems to make it evident that while it is from Wizden, but not part of our normal upstream merges. If they ever do add clown waddling again, putting it in a separate folder should make it easier for us to rip it out (or keep it if we don't like how upstream changes it.)

While this does fix the most glaring issues with the previous waddling system, there are a few known issues:

• Toggling clown waddling on while moving will not immediately make you start waddling, you will need to let go of your movement input and press it again to start the animation
• If you are put into crit while moving with clown waddling on, it may take a second before you will fall over. This is much more preferable to how it was previously where you would endlessly waddle while crit or dead. (It is also a little funny that there's a small delay to you falling over.)
• The WaddlingWhenWorn system is controlled by the ItemToggle system, which also controls the ClothingSpeedModifier component. This means that the large clown shoes will only slow you down if you are waddling. There does not seem to be a way to make it so the ClothingSpeedModifier component is always on without changing how it works.

With all this in mind, I still think it's worth bringing our funny walks back.

clownwaddlingreturn.mp4

Changelog

🆑

• add: Clown shoe waddling has been re-implemented with a fix that will prevent the waddling animation from playing when it should not be. Additionally, it has been changed into a toggle system, similar to magboots.