Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contraband Reagent System + Contraband Produce #1275

Merged
merged 4 commits into from
Jan 11, 2025

Conversation

Pinkbat5
Copy link

@Pinkbat5 Pinkbat5 commented Jan 9, 2025

Ports space-wizards#33184 and marks a bunch of reagents as contraband (both upstream and imp-exclusive). Also marks three botany plants as contraband, which isn't directly related to the new contraband reagent system, but seemed fitting. Rainbow weed is minor contraband, death nettle and fly amanita are major.

For ease of review, here is every reagent that is now contraband, sorted by tier:
Minor

  • Forever weed
  • Norepinephric acid (makes you blind)
  • Space mirage (its description literally says it's illegal lol)
  • Phlogiston
  • BROSochloric BROS
  • Buzzochloric bees
  • Mindbreaker toxin

Major

  • Chlorine trifluoride
  • Napalm
  • Thermite
  • Amatoxin
  • Heartbreaker toxin
  • Holium

Tier 2 Syndicate (Subterfuge)

  • Subjuzine (inert and activated)
  • Mute toxin
  • Nocturine
  • Vestine

Tier 3 Syndicate (Military)

  • Hyperzine
  • Lexorin
  • Romerol
  • Tazinide

I tried to only mark chemicals as contraband if their only use is hurting people. Mutagen and other actually-useful chemicals are not marked for this reason, despite their clear killing potential.
This is because unfortunately, I can specify a reagent is "departmentally restricted" but I can't choose the department it's restricted to. So, departmental restrictions are absent from this PR. Please let me know if you can figure out a way to specify department!

I'm open to feedback on some of these classifications, I'm especially unsure about the pyrokinetic chemicals because I don't dabble in that side of chem. Chemists have been able to fuck around with explosives freely in the past, and this would make that firmly illegal without captain approval-- a good change in my opinion, but maybe not everyone will feel that way.
Might cause problems for botanists too, if their lucky-roll plant that makes omnizine also happens to produce something illegal. Security will need to understand that these mutations happen in botany sometimes, and will need to be able to draw a line between accidental and deliberate production.

Screenshot 2025-01-08 225154
Screenshot 2025-01-08 225127
image2222

Changelog

🆑

  • tweak: Some of the dangerous reagents have been marked as contraband. Check the chemical guidebook to see what is and isn't illegal!
  • tweak: Rainbow weed, fly amanita and death nettles are now contraband.
  • add: The detective's forensic pad can now be used to detect the reagents in any sample of liquid.

@hivehum
Copy link

hivehum commented Jan 10, 2025

add contraband tag to green marijuana please

@Pinkbat5
Copy link
Author

Pinkbat5 commented Jan 10, 2025

add contraband tag to green marijuana please

bad news
image
they legalized it..........

@hivehum
Copy link

hivehum commented Jan 10, 2025

add contraband tag to green marijuana please

bad news image

THIS ISSNT TRUE. ITS ILLEGAL

Copy link

@mqole mqole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not super clear that the colour of the reagent on the forensic pad is tied to its contraband level, especially since reagents have their own colours which are usually displayed on examine text. but theres text about it in the forensics guidebook so its probably fine.

it would be cool if hydroponics trays with plants growing in them Also had a contraband classification. this might encourage botanists to be a bit sneakier.
image

wrt departmental classifications, there are existing tags for this defined in base_contraband.yml, but applying them didnt show any restrictive tags show up. issue for a later day

@mqole mqole merged commit 9962676 into impstation:master Jan 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants