Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weaker ninja gloves #1230

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Weaker ninja gloves #1230

merged 2 commits into from
Jan 9, 2025

Conversation

iaada
Copy link

@iaada iaada commented Jan 4, 2025

Continuing with ninja stuff. Nerf to the stun duration (5 -> 3), cooldown (2 -> 30), and energy cost (36j -> 180j; half a small battery) of gloves. It remains an instant stun, but can't be used to solo all of security.

PR also adds a ninja stamp, and migrates an old impstation stamp to _Imp.

🆑 aada

  • add: Ninja sword can now stamp papers.
  • tweak: Ninja gloves now have a much weaker stun.

@honeyed-lemons
Copy link

I think the power nerf is a Little Much, maybe 90?

@Darkmajia
Copy link

it does seem a bit much, and the cooldown is huuuuuuge. i'll think on it (or wait for more people's thoughts) but i do think ninja's instant stun is crazy currently

@iaada
Copy link
Author

iaada commented Jan 6, 2025

My thoughts on the gloves stun is that it's absurd as is. You can use it to take out an entire security team and not feel any consequences. With this nerf you can still freely escape a 1v1 or slip past a guard, but doing so carries a heavy cost. I feel it's more fun for both people if you fight honorably with your sword.

@Darkmajia
Copy link

after thinking on it a bit more i'm okay with trying it out, but i feel like splitting the gloves makes it harder to keep track of any changes to the base gloves. or at the very least, they should parent the upstream ninja gloves

@DVDPlayerOfDiscordFame
Copy link

I'm really on board with this. The instant spammable stun is honestly too strong, and if we want to make Ninja a role that's actually trying to be stealthy it does mean we need to make direct confrontation costly and even risky. If the stun cost isn't dynamic with the power cell's size and has to be a fixed number, I wouldn't make the number smaller than 120j (1/3rd a small power cell's size).

@iaada
Copy link
Author

iaada commented Jan 8, 2025

Reparented to the wiz gloves and wiz katana. I understand that making a new prototype could end up causing desync with upstream changes, but the alternative is merge conflicts which has its own set of issues.

@Darkmajia Darkmajia merged commit 06cdba3 into impstation:master Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants