Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: load the form template only on single pages #7662

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Dec 26, 2024

Resolves GIVE-928

Description

This PR fixes a bug that prevents the archive page get loading properly due to a wrong load of the single template for donation forms. Now we are ensuring that the donation form single template is loaded only for single pages.

Affects

The archive donation forms page.

Visuals

image

Testing Instructions

  1. Create a V2 form, then a VFB form.
  2. Check the /donations/ page and NOT only the VFB form will show (as was happening before) but both

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Dec 26, 2024
@glaubersilva glaubersilva marked this pull request as ready for review December 26, 2024 18:17
@pauloiankoski pauloiankoski self-requested a review January 6, 2025 15:54
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests.

@glaubersilva glaubersilva merged commit 5c03e2b into develop Jan 9, 2025
20 checks passed
@glaubersilva glaubersilva deleted the fix/forms-archive-template-GIVE-928 branch January 9, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants