Enhancement: improve data validation for the give_clean() function #7661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GIVE-2063
Description
This PR changes the
give_clean()
function to prevent unserializing data by default, now we are unserializing only when the$allow_serialized_data
istrue
, otherwise, we are returning an empty string when data is serialized.This PR also improves the regex used in the
containsSerializedDataRegex()
to cover all data types instead of only arrays and objects.Affects
As many places are using the
give_clean()
function, these changes affect the entire codebase, especially the submission of new donations.Visuals
V2 form error message:
V3 form error message:
Testing Instructions
a:1:{s:4:"Test";s:15:"serialize here!";}
Error: Please enter your first name.
message.a:1:{s:4:"Test";s:15:"serialize here!";}
First name is required
message.Pre-review Checklist
@unreleased
tags included in DocBlocks