Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: change font-size for modal input descriptions #7650

Merged

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Dec 16, 2024

Resolves GIVE-2035

Description

This PR changes the font size of the input descriptions used inside the modals on the campaigns page.

Affects

  • The "create campaign" modal
  • The "merge campaign" modal

Visuals

image

image

Testing Instructions

Open the "create campaign" and "merge campaign" modals and make sure the font size for the input descriptions is displayed in the proper size.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Dec 16, 2024
@glaubersilva glaubersilva changed the title Refactor: change modal description font size Refactor: change font-size for modal input descriptions Dec 16, 2024
@glaubersilva glaubersilva marked this pull request as ready for review December 16, 2024 14:08
@jdghinson
Copy link
Contributor

@glaubersilva I noticed we are using grey-400 instead of neutral-500 for the description and the title is supposed to be neutral-700 instead of grey-700

@glaubersilva
Copy link
Contributor Author

@jdghinson I just updated the font color for the title and description. Let me know if there is anything else preventing this PR from getting approved. Thanks!

Copy link
Contributor

@jdghinson jdghinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! 🖊️

@glaubersilva glaubersilva merged commit a26e2f6 into epic/campaigns Dec 20, 2024
20 checks passed
@glaubersilva glaubersilva deleted the refactor/modal-description-font-size-GIVE-2010 branch December 20, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants