Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Donation confirmation email - donation description #7602

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

alaca
Copy link
Member

@alaca alaca commented Nov 4, 2024

Description

This PR resolves the issue with the wrong donation description in the confirmation email. The problem affects V3 forms only because there is a missing meta key (_give_payment_price_id) which is used to determine the donation level. The issue is resolved by checking if the donation form is a V3 form and then comparing the donation amount with the donation level amount set in form settings.

Affects

Donation receipt email

Testing Instructions

  • Create a donation form with multiple donation levels.
  • Give each donation level a different description.
  • Donate to any level other than the first level.
  • Check the donation description in the donation confirmation

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Self Review of code and UX completed

@alaca alaca requested a review from jonwaldstein November 19, 2024 13:52
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready for QA 🌈

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@jonwaldstein jonwaldstein merged commit 4e89033 into develop Nov 20, 2024
20 checks passed
@jonwaldstein jonwaldstein deleted the fix/donation-amount-description-GIVE-1204 branch November 20, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants