Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: update constantcontact form meta decorator #7580

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Refactor: update constantcontact form meta decorator #7580

merged 8 commits into from
Nov 20, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Oct 22, 2024 •
edited
Loading

Resolves: GIVE-2002

Description

This PR updates the global option meta in the decorator and tests to reflect the new optionkeys with the givewp prefix.

Affects

migrating v2-v3 forms using ConstantContact

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review October 30, 2024 21:43
jonwaldstein
jonwaldstein approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rickalday
rickalday approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JoshuaHungDinh JoshuaHungDinh merged commit 244944b into develop Nov 20, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the refactor/cc-form-meta-decorator branch November 20, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonwaldstein jonwaldstein jonwaldstein approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaHungDinh @rickalday @jonwaldstein